-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
magic-enum: 0.8.2 -> 0.9.5 #294551
magic-enum: 0.8.2 -> 0.9.5 #294551
Conversation
Result of 1 package failed to build:
11 packages built:
|
Result of 1 package marked as broken and skipped:
5 packages failed to build:
6 packages built:
|
Result of 1 package marked as broken and skipped:
5 packages failed to build:
6 packages built:
|
Result of 1 package failed to build:
11 packages built:
|
Actually, something is still wrong.
while the new one contains:
So there is obviously some CMake magic that is escaping the |
Result of 1 package marked as broken and skipped:
5 packages failed to build:
6 packages built:
|
Result of 12 packages built:
|
Result of 1 package marked as broken and skipped:
5 packages failed to build:
6 packages built:
|
Result of 12 packages built:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. i tested it on my project i originally packaged it for. there doesn't seem to be any problems.
@ofborg eval |
Description of changes
Changelog: https://github.com/Neargye/magic_enum/releases/tag/v0.9.5
I faced the issue described in #144170 but fixed it by doing the same thing as in #71669.
Also, I re-enabled the tests as they have since been fixed.
cc @Alper-Celik
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.